Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SYCL][Bindless] Add image_mem_handle to image_mem_handle devices copies. #12449

Merged
merged 55 commits into from
Apr 25, 2024

Conversation

cppchedy
Copy link
Contributor

@cppchedy cppchedy commented Jan 19, 2024

Add support for device to device copy for image_mem_handle to image_mem_handle.

@cppchedy cppchedy changed the title [Bindless] Add image_mem_handle to image_mem_handle devices copies. [SYCL][Bindless] Add image_mem_handle to image_mem_handle devices copies. Jan 19, 2024
@cppchedy cppchedy force-pushed the chedy/device-to-device-copy branch from cc99ee3 to ed2b572 Compare January 19, 2024 17:09
@cppchedy cppchedy marked this pull request as ready for review January 19, 2024 17:11
@cppchedy cppchedy requested review from a team as code owners January 19, 2024 17:11
@cppchedy
Copy link
Contributor Author

cppchedy commented Feb 5, 2024

CI is now passing, tagging @intel/unified-runtime-reviewers and @intel/llvm-reviewers-runtime for reviews

@cppchedy
Copy link
Contributor Author

Friendly ping @intel/llvm-reviewers-runtime, @intel/unified-runtime-reviewers and @sergey-semenov for reviews.

@againull againull self-requested a review April 3, 2024 16:47
sycl/source/handler.cpp Show resolved Hide resolved
@cppchedy
Copy link
Contributor Author

Associated UR PR oneapi-src/unified-runtime#1265

Comment on lines 117 to 118
https://github.com/cppchedy/unified-runtime.git
f9fb11670f49eb8080cd721d681005e508fd2cc5
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oneapi-src/unified-runtime#1265 is merged. We are using the main tag just now so if you could update that instead of this to point at this commit that'd be very helpful.

commit 7fcfe3ad8882fee23d83fa0fc4c4c944262a9ea3
Merge: b37fa2c4 f9fb1167
Author: Kenneth Benzie (Benie) <[email protected]>
Date:   Wed Apr 24 10:38:00 2024 +0100

    Merge pull request #1265 from cppchedy/chedy/device-to-device-copy

    [Bindless][Exp] Add support for device to device copies between CuArrays

@kbenzie
Copy link
Contributor

kbenzie commented Apr 25, 2024

@intel/llvm-gatekeepers please merge

@sommerlukas sommerlukas merged commit 1e2e6ba into intel:sycl Apr 25, 2024
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants